)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"96f0167d7e87ce32d4447728805db33062264135","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3fdb804_70a7d57d","updated":"2025-08-05 06:21:37.000000000","message":"Hmm, this unconditionally pulls in a bunch of new stuff for consumers of nix-compat. We probably want to feature-gate things there?","commit_id":"69c29d077888a306494ff24e68420aa6c8b5b18f"},{"author":{"_account_id":1000014,"name":"Brian Olsen","display_name":"griff","email":"brian@maven-group.org","username":"griff"},"change_message_id":"50ca955f96d4625cd670ed1b9a11dbac4b8e40f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"256a857c_28e7185b","in_reply_to":"f3fdb804_70a7d57d","updated":"2025-08-05 09:17:30.000000000","message":"Yeah the default features of serde_with pulls in too much.\n\nIt seems to be a bug in either serde_with or cargo because when using `dep?/feature` syntax in a `Cargo.toml` where `dep` is another feature instead of a dependency cargo seems to just unconditionally pull in that feature and thus enabling the optional dependency. Which is exactly what the `?/feature` part should prevent.\n\nAnyway I have now reduced the features on serde_with so it pulls in fewer dependencies. If that is still too many it might make sense to not use serde_with at all or to add something like a serde feature gate to nix-compat.","commit_id":"69c29d077888a306494ff24e68420aa6c8b5b18f"}],"snix/nix-compat/src/nixhash/algos.rs":[{"author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"e45b82341f2370701f9bab635635fa4dffcae955","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/// TODO(Raito): this could be automated via macros, I suppose."},{"line_number":41,"context_line":"/// But this may be more expensive than just doing it by hand"},{"line_number":42,"context_line":"/// and ensuring that is kept in sync."},{"line_number":43,"context_line":"pub const SUPPORTED_ALGOS: [\u0026str; 4] \u003d [\"md5\", \"sha1\", \"sha256\", \"sha512\"];"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"1e485186_124672c2","line":40,"updated":"2025-08-04 22:03:05.000000000","message":"Unrelated: I don\u0027t think we still want to macro-ify this. Can you add a CL dropping this?","commit_id":"e445a9660fca821f1828a61d20722903635663f6"},{"author":{"_account_id":1000014,"name":"Brian Olsen","display_name":"griff","email":"brian@maven-group.org","username":"griff"},"change_message_id":"ca8271b26d89c5ef4a4a4548d0cbbfa40d1d27e9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"/// TODO(Raito): this could be automated via macros, I suppose."},{"line_number":41,"context_line":"/// But this may be more expensive than just doing it by hand"},{"line_number":42,"context_line":"/// and ensuring that is kept in sync."},{"line_number":43,"context_line":"pub const SUPPORTED_ALGOS: [\u0026str; 4] \u003d [\"md5\", \"sha1\", \"sha256\", \"sha512\"];"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"f6caf90b_46b6a0c0","line":40,"in_reply_to":"1e485186_124672c2","updated":"2025-08-04 22:41:06.000000000","message":"Done!","commit_id":"e445a9660fca821f1828a61d20722903635663f6"}]}