)]}'
{"id":"snix~30588","triplet_id":"snix~canon~I81fd8e342fc877344f8d2a3704ef53caf5190aa3","project":"snix","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000035":{"account":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},"last_update":"2025-06-29 20:07:36.000000000","reason":"removed on reply"},"1000004":{"account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-06-30 08:25:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change","reason_account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}},"1000009":{"account":{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},"last_update":"2025-06-30 02:26:44.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I81fd8e342fc877344f8d2a3704ef53caf5190aa3","subject":"feat(snix/eval): proper error handling for invalid regexes","status":"MERGED","created":"2025-06-29 18:19:44.000000000","updated":"2025-06-30 13:50:12.000000000","submitted":"2025-06-30 13:50:12.000000000","submitter":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"30588","meta_rev_id":"cff29b9920ff65581622a2e1d1ce54c5584028ab","_number":30588,"virtual_id_number":30588,"owner":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-30 13:50:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-06-30 13:50:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Verified":{"approved":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-06-30 13:50:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"optional":true},"Autosubmit":{"all":[{"value":0,"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-29 18:19:44.000000000","updated_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},"state":"REVIEWER"},{"updated":"2025-06-29 18:19:44.000000000","updated_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},"state":"REVIEWER"},{"updated":"2025-06-29 18:19:45.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-06-29 18:35:27.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a6c785b30f2f2409acfd364e2b20e038403ceb2d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-29 18:19:44.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"28334b7635a6809e404cf1d7ca4c532eb99026bc","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-29 18:19:45.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/snix/snix/builds/1391","accounts_in_message":[],"_revision_number":1},{"id":"d60c7612ac6d1bf210d363c2ef02a7ab4866e332","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-29 18:21:16.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3a7e3e964b0411c5e842365e36a408d036aedb07","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-29 18:21:18.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/snix/snix/builds/1392","accounts_in_message":[],"_revision_number":2},{"id":"5c95ecb46bd439b08eb6af55f534ff4dd68643ec","tag":"autogenerated:buildkite~result","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-29 18:35:27.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/snix/snix/builds/1392","accounts_in_message":[],"_revision_number":2},{"id":"14c100a877f020135116c5f46e41ff845739af25","author":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},"date":"2025-06-29 19:40:15.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"62d881fb7c6d77f44461727bfb5202b17125cd28","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-29 19:54:40.000000000","message":"Patch Set 3: Published edit on patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"26d9be5ebb81f653707774e8e80373105a541a30","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-29 19:54:41.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/snix/snix/builds/1393","accounts_in_message":[],"_revision_number":3},{"id":"15443e8a446b39246ac53ad79b4b423ef64fc25c","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-29 19:54:46.000000000","message":"Patch Set 3: Autosubmit+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e8ee08e3086b62d8097ce2bd8f773436f0a99274","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-29 20:01:20.000000000","message":"Patch Set 4: Patch Set 3 was rebased\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"c1998affd3972b1901d790f3b89285b979e1ba8c","author":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"},"date":"2025-06-29 20:07:36.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"fbcf79b64af505779cda2932ea867ec7ce0988ec","tag":"autogenerated:buildkite~result","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-29 20:18:56.000000000","message":"Patch Set 3: Verified-1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified-1 has been copied to patch set 4 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 3 failed: https://buildkite.com/snix/snix/builds/1393","accounts_in_message":[],"_revision_number":3},{"id":"4b83e0b68d14a56240185e036f15acca9a3a1184","author":{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},"date":"2025-06-30 02:26:44.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"2c4c1535c9faa75393cb6011dabb883afe0af6a0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-30 08:24:22.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"60d5fe9cd3768242eb7669160d2281c2e3e6715f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-30 08:24:23.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/snix/snix/builds/1394","accounts_in_message":[],"_revision_number":5},{"id":"45b7ddcd84ab915c1ebaa54908f8a1e2a74f1e2d","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-30 08:25:20.000000000","message":"Patch Set 5: -Autosubmit","accounts_in_message":[],"_revision_number":5},{"id":"fa1b11fc07e879ee4068d31112ae07191755303a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-30 08:31:51.000000000","message":"Uploaded patch set 6.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"111c4cde86c8401508d62b5a98101e7186f19a06","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-30 08:31:52.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/snix/snix/builds/1395","accounts_in_message":[],"_revision_number":6},{"id":"2f877826883d688affb6d9ee76060e50bb4ea81b","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-30 08:32:58.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"d2b234dc03a29b10bdfd976a4aea2024f401044d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-06-30 08:46:30.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/snix/snix/builds/1395","accounts_in_message":[],"_revision_number":6},{"id":"cff29b9920ff65581622a2e1d1ce54c5584028ab","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-06-30 13:50:12.000000000","message":"Change has been successfully rebased and submitted as 3c1a7176cbae67ebda31c4ee5400bd5e551c4003\n\n4 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: snix/eval/src/builtins/mod.rs\nInsertions: 5, Deletions: 4.\n\n@@ -991,8 +991,9 @@\n             return Ok(re);\n         }\n         let re \u003d re.to_str()?;\n-        let re: Regex \u003d cached_regex(\u0026format!(\"^{}$\", re.to_str()?))\n-            .map_err(|_| ErrorKind::InvalidRegex(re))?;\n+        let re \u003d re.to_str()?;\n+        let re: Regex \u003d cached_regex(\u0026format!(\"^{}$\", re))\n+            .map_err(|_| ErrorKind::InvalidRegex(re.to_string()))?;\n \n         match re.captures(s.to_str()?) {\n             Some(caps) \u003d\u003e Ok(Value::List(\n@@ -1213,8 +1214,8 @@\n         let s \u003d str.to_contextful_str()?;\n         let text \u003d s.to_str()?;\n         let re \u003d regex.to_str()?;\n-        let re \u003d cached_regex(re.to_str()?)\n-            .map_err(|_| ErrorKind::InvalidRegex(re))?;\n+        let re \u003d re.to_str()?;\n+        let re \u003d cached_regex(re).map_err(|_| ErrorKind::InvalidRegex(re.to_string()))?;\n         let mut capture_locations \u003d re.capture_locations();\n         let num_captures \u003d capture_locations.len();\n         let mut ret \u003d Vec::new();\n```\n```\nThe name of the file: snix/eval/src/errors.rs\nInsertions: 1, Deletions: 1.\n\n@@ -297,7 +297,7 @@\n \n     /// An invalid regular expression was passed.\n     #[error(\"invalid regular expression \u0027{0}\u0027\")]\n-    InvalidRegex(NixString),\n+    InvalidRegex(String),\n }\n \n impl error::Error for Error {\n```\n","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"3c1a7176cbae67ebda31c4ee5400bd5e551c4003","revisions":{"642843397e10340d002dfc697dde40d8fc536cf1":{"kind":"REWORK","_number":1,"created":"2025-06-29 18:19:44.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/1","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/1","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/1"}}},"commit":{"parents":[{"commit":"16a06ef667f1f4dae655b9ac3180b11153f1d591","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:19:37.000000000","tz":180},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon"},"01d47019bc219c93aadeb087dc2cdebdcdd14d53":{"kind":"REWORK","_number":2,"created":"2025-06-29 18:21:16.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/2","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/2","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/2"}}},"commit":{"parents":[{"commit":"16a06ef667f1f4dae655b9ac3180b11153f1d591","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:21:13.000000000","tz":180},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon"},"fe3cd957b896067cc940593d5359aff488ba42e6":{"kind":"REWORK","_number":3,"created":"2025-06-29 19:54:40.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/3","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/3","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/3"}}},"commit":{"parents":[{"commit":"16a06ef667f1f4dae655b9ac3180b11153f1d591","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 19:54:35.000000000","tz":0},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon"},"eb9b6ff1f24f204ee7e34b7a7ced037b097114ec":{"kind":"NO_CHANGE","_number":4,"created":"2025-06-29 20:01:20.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/4","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/4","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/4"}}},"commit":{"parents":[{"commit":"4de1129acbd749e9605695259d83ad6383a6108d","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 20:01:20.000000000","tz":0},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon","description":"Rebase","conflicts":{"ours":"fe3cd957b896067cc940593d5359aff488ba42e6","theirs":"4de1129acbd749e9605695259d83ad6383a6108d","contains_conflicts":false}},"4baf07d36ed1e43afd518aa758fbdcdf94d5ee93":{"kind":"REWORK","_number":5,"created":"2025-06-30 08:24:22.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/5","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/5","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/5"}}},"commit":{"parents":[{"commit":"4de1129acbd749e9605695259d83ad6383a6108d","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-30 08:24:14.000000000","tz":180},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon"},"d6bd5959abb9917e652cb3d218a9063f4e23d9d4":{"kind":"REWORK","_number":6,"created":"2025-06-30 08:31:51.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/6","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/6","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/6"}}},"commit":{"parents":[{"commit":"4de1129acbd749e9605695259d83ad6383a6108d","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-30 08:31:41.000000000","tz":180},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\n"},"branch":"refs/heads/canon"},"3c1a7176cbae67ebda31c4ee5400bd5e551c4003":{"kind":"NO_CODE_CHANGE","_number":7,"created":"2025-06-30 13:50:12.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/88/30588/7","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/88/30588/7","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/88/30588/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/88/30588/7"}}},"commit":{"parents":[{"commit":"4de1129acbd749e9605695259d83ad6383a6108d","subject":"refactor(snix/eval): cache regexes for builtins"}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-29 18:17:39.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-06-30 13:50:12.000000000","tz":0},"subject":"feat(snix/eval): proper error handling for invalid regexes","message":"feat(snix/eval): proper error handling for invalid regexes\n\nWe don\u0027t want to crash the evaluator when an invalid regex is passed,\nbut instead display a user-facing error message. This CL does that.\n\nChange-Id: I81fd8e342fc877344f8d2a3704ef53caf5190aa3\nReviewed-on: https://cl.snix.dev/c/snix/+/30588\nReviewed-by: Vova Kryachko \u003cv.kryachko@gmail.com\u003e\nTested-by: besadii\nReviewed-by: Bence Nemes \u003cnemes.bence1@gmail.com\u003e\n"},"branch":"refs/heads/canon","description":"Rebase","conflicts":{"ours":"d6bd5959abb9917e652cb3d218a9063f4e23d9d4","theirs":"4de1129acbd749e9605695259d83ad6383a6108d","contains_conflicts":false}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1000035,"name":"Bence Nemes","email":"nemes.bence1@gmail.com","username":"starnick4444"}},{"label":"Verified","status":"MAY","applied_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]}},{"label":"Autosubmit","status":"MAY"}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"Verified","description":"Label \u0027Verified+1\u0027 is required","status":"SATISFIED","is_legacy":false,"applicability_expression_result":{"fulfilled":true,"status":"PASS"},"submittability_expression_result":{"expression":"label:Verified\u003dMAX,user\u003dnon_uploader","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX,user\u003dnon_uploader"],"failing_atoms":[],"atom_explanations":{"label:Verified\u003dMAX,user\u003dnon_uploader":""}}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"At least one maximum vote for label \u0027Code-Review\u0027 is required, minimum votes block submits","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX,user\u003dnon_uploader"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX,user\u003dnon_uploader":"","label:Code-Review\u003dMIN":""}}},{"name":"No-Unresolved-Comments","description":"Changes that have unresolved comments are not submittable.","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"-has:unresolved","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}}]}