)]}'
{"id":"snix~30263","triplet_id":"snix~canon~Ib53edaec77a1a0aa2663287d973d398274fde79a","project":"snix","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2025-03-23 18:29:04.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"}},"1000004":{"account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-03-23 18:24:10.000000000","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change","reason_account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}}},"hashtags":[],"change_id":"Ib53edaec77a1a0aa2663287d973d398274fde79a","subject":"fix(snix/store/import): don\u0027t unsafely construct OsStr","status":"MERGED","created":"2025-03-23 18:17:39.000000000","updated":"2025-03-23 18:29:10.000000000","submitted":"2025-03-23 18:29:10.000000000","submitter":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"30263","meta_rev_id":"9d9141781606fd863e070b55df92f69037baebce","_number":30263,"virtual_id_number":30263,"owner":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-23 18:29:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Verified":{"approved":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-23 18:29:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"optional":true},"Autosubmit":{"all":[{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-23 18:17:39.000000000","updated_by":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2025-03-23 18:17:40.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-23 18:26:34.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3c257b32ccb7b31c66640a6d3e8312f4624fe8ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2025-03-23 18:17:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"589349b4e8e5a4ab00bf75b06d1578fd14f6bf5b","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2025-03-23 18:17:39.000000000","message":"\u003cGERRIT_ACCOUNT_1000004\u003e, who was added as reviewer owns the following files:\n* `snix/store/src/import.rs`\n","accounts_in_message":[{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"40c17054f4966a20d4743d4c6d1244cef49ef922","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-03-23 18:17:40.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/snix/snix/builds/863","accounts_in_message":[],"_revision_number":1},{"id":"0a222da34c985691798aff11290c0c027ea125f7","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-23 18:20:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4da0da7d566973657633ab09206a0bd1f8e009bf","author":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2025-03-23 18:23:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f27935cfb6b1325027739a81a6abb0c4e7191b38","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-23 18:24:10.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cf7a4b3eafaa32071d7b8c612733050df81de95a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-03-23 18:26:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/snix/snix/builds/863","accounts_in_message":[],"_revision_number":1},{"id":"785be01ef950038e03c770e19b1a35277beb800d","author":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2025-03-23 18:29:04.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9d9141781606fd863e070b55df92f69037baebce","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2025-03-23 18:29:10.000000000","message":"Change has been successfully rebased and submitted as 7a2e70062cf0932ac27c2dbc9c41cbdc1ac21a38","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7a2e70062cf0932ac27c2dbc9c41cbdc1ac21a38","revisions":{"1260b5b380231b16aa031f38107992994d5e6aa4":{"kind":"REWORK","_number":1,"created":"2025-03-23 18:17:39.000000000","uploader":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/63/30263/1","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/63/30263/1","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/63/30263/1"}}},"commit":{"parents":[{"commit":"c9f2e14f21b2b3958f7d579610e68f62bd517a0f","subject":"chore(contrib/weave): bump some crate dependencies"}],"author":{"name":"edef","email":"edef@edef.eu","date":"2025-03-23 18:15:21.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2025-03-23 18:17:17.000000000","tz":0},"subject":"fix(snix/store/import): don\u0027t unsafely construct OsStr","message":"fix(snix/store/import): don\u0027t unsafely construct OsStr\n\nWhat we\u0027re doing is safe on POSIX, but not elsewhere, so we should use\nthe Unix-only safe OsStr::from_bytes method rather than adding unsafety.\n\nChange-Id: Ib53edaec77a1a0aa2663287d973d398274fde79a\n"},"branch":"refs/heads/canon"},"7a2e70062cf0932ac27c2dbc9c41cbdc1ac21a38":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-03-23 18:29:10.000000000","uploader":{"_account_id":1000001,"name":"edef","display_name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/63/30263/2","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/63/30263/2","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/63/30263/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/63/30263/2"}}},"commit":{"parents":[{"commit":"1859e517da584c0b53d0e91255a7b50c3300b2ff","subject":"chore(snix/store): edition 2021 -\u003e 2024"}],"author":{"name":"edef","email":"edef@edef.eu","date":"2025-03-23 18:15:21.000000000","tz":0},"committer":{"name":"edef .","email":"edef@edef.eu","date":"2025-03-23 18:29:10.000000000","tz":0},"subject":"fix(snix/store/import): don\u0027t unsafely construct OsStr","message":"fix(snix/store/import): don\u0027t unsafely construct OsStr\n\nWhat we\u0027re doing is safe on POSIX, but not elsewhere, so we should use\nthe Unix-only safe OsStr::from_bytes method rather than adding unsafety.\n\nChange-Id: Ib53edaec77a1a0aa2663287d973d398274fde79a\nReviewed-on: https://cl.snix.dev/c/snix/+/30263\nTested-by: besadii\nReviewed-by: Florian Klink \u003cflokli@flokli.de\u003e\n"},"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"MAY","applied_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]}},{"label":"Autosubmit","status":"MAY"}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"Code-Review","description":"A maximum vote from a non-uploader is required for the \u0027Code-Review\u0027 label. A minimum vote is blocking.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX,user\u003dnon_uploader"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Verified","description":"Label \u0027Verified+1\u0027 is required","status":"SATISFIED","is_legacy":false,"applicability_expression_result":{"fulfilled":true,"status":"PASS"},"submittability_expression_result":{"expression":"label:Verified\u003dMAX,user\u003dnon_uploader","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX,user\u003dnon_uploader"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[],"atom_explanations":{}}},{"name":"No-Unresolved-Comments","description":"Changes that have unresolved comments are not submittable.","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"-has:unresolved","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}}]}