)]}'
{"id":"snix~30090","triplet_id":"snix~canon~Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752","project":"snix","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000000":{"account":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},"last_update":"2025-03-18 11:39:13.000000000","reason":"\u003cGERRIT_ACCOUNT_1000000\u003e replied on the change","reason_account":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"}},"1000004":{"account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"last_update":"2025-03-18 11:41:04.000000000","reason":"\u003cGERRIT_ACCOUNT_1000004\u003e replied on the change","reason_account":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}},"1000009":{"account":{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},"last_update":"2025-03-18 12:06:33.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752","subject":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal","status":"MERGED","created":"2025-03-18 10:56:03.000000000","updated":"2025-03-18 12:06:33.000000000","submitted":"2025-03-18 12:06:33.000000000","submitter":{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"30090","meta_rev_id":"3b043b1b33c9481d161d8bcfa9cf7c999bf27fef","_number":30090,"virtual_id_number":30090,"owner":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2025-03-18 12:06:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0,"optional":true},"Verified":{"approved":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-18 12:06:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"optional":true},"Autosubmit":{"approved":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2025-03-18 12:06:33.000000000","_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"}],"reviewers":{"REVIEWER":[{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-03-18 10:56:03.000000000","updated_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000009,"name":"Vova Kryachko","email":"v.kryachko@gmail.com","username":"vkryachko"},"state":"REVIEWER"},{"updated":"2025-03-18 10:56:04.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2025-03-18 11:19:45.000000000","updated_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2025-03-18 12:06:13.000000000","updated_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-03-18 12:06:33.000000000","updated_by":{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"470d1a695bb77a8829fc2494ebe59c71d0a4370f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 10:56:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"37555d6707d5479edb13a79b2f880b5e63cc8b6d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-03-18 10:56:04.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/snix/snix/builds/571","accounts_in_message":[],"_revision_number":1},{"id":"f56efb9c9b639435defc3fb9a69eff44ded11ff0","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 11:10:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8bd1bf162dd37126321dee734f224b426d7f8381","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 11:19:45.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"086af9039c173fa7a605ea7eea54196c3ec8864b","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 11:19:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"903cc573d8a8a0bd295a8cafc7ab542ee7f02d62","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-03-18 11:19:46.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/snix/snix/builds/576","accounts_in_message":[],"_revision_number":2},{"id":"fc1555ec1a8e93a956322a2ce96343ee44128cd3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 11:20:21.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"2e10848bd5142b74370b444e4f92e7bb5eec6999","author":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"},"date":"2025-03-18 11:39:13.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e89550b3159679a3538a5c3bcbced61d612f562e","author":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"date":"2025-03-18 11:41:04.000000000","message":"Patch Set 3: Autosubmit+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"876e288ea5310492377a61c2af42fe76c4b198d4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]},"date":"2025-03-18 12:06:13.000000000","message":"Patch Set 2: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 3 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 2 passed: https://buildkite.com/snix/snix/builds/579","accounts_in_message":[],"_revision_number":2},{"id":"3b043b1b33c9481d161d8bcfa9cf7c999bf27fef","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},"date":"2025-03-18 12:06:33.000000000","message":"Change has been successfully rebased and submitted as 64f8cb1400f2b49693f360755805f4debd466fc6","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"64f8cb1400f2b49693f360755805f4debd466fc6","revisions":{"6c88f0937e47947fdc5b7e9b42e97b3ba6fbd6f1":{"kind":"REWORK","_number":1,"created":"2025-03-18 10:56:03.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/30090/1","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/90/30090/1","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/90/30090/1"}}},"commit":{"parents":[{"commit":"bca46bf1cff57bc1c0c3c78a6864a1cfa173b063","subject":"chore(snix/nix-daemon): Fix queryValidPaths operation."}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-17 19:18:50.000000000","tz":0},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-18 10:55:50.000000000","tz":0},"subject":"fix(snix/shell): fix cargo test invocation without Nix 2.3","message":"fix(snix/shell): fix cargo test invocation without Nix 2.3\n\nUnfortunately, we still need to provide a Nix version in the shell, due\nto nix_oracle failing (change of laziness in Nix between 2.3 and current\nNix).\n\nIt however doesn\u0027t seem to fail in Lix, and that actually shows build\nlogs if people are running a non-Nix 2.3 version, so let\u0027s use that.\n\nChange-Id: Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752\n"},"branch":"refs/heads/canon"},"48e5e466b40f15bc75b497ba7175ad2fbde8a220":{"kind":"REWORK","_number":2,"created":"2025-03-18 11:19:45.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/30090/2","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/90/30090/2","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/90/30090/2"}}},"commit":{"parents":[{"commit":"bca46bf1cff57bc1c0c3c78a6864a1cfa173b063","subject":"chore(snix/nix-daemon): Fix queryValidPaths operation."}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-17 19:18:50.000000000","tz":0},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-18 11:11:41.000000000","tz":0},"subject":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal","message":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal\n\nThis was using a constant, which is fine to eagerly evaluate (as it\nis constant, saves thunking and won\u0027t cause any observable side-effects).\n\nNix probably started eagerly evaluating these at some point, and after\nsome discussion with Robert and Raito, it looks like this is fine and\nLix (where it still is lazy right now) might be open to backport it.\n\nChange the testcase to be a bit more complicated (using `12 + 1`\ninstead of `12`), which still tests what the test wants to primarily\ntest, without failing on these (irrelevant) changes in laziness.\n\nThis means we don\u0027t need to pull in a specific version of Nix in our\nshell.\nThis fixes seeing nix build logs while in the tvix-shell, which was\nbroken on machines not running Nix 2.3.\n\nSee-Also: https://github.com/NixOS/nix/issues/12666\nChange-Id: Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752\n"},"branch":"refs/heads/canon"},"d00c94aecb47e445bc96a90fab6d8e1b203ff4a4":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-03-18 11:20:21.000000000","uploader":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/90/30090/3","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/90/30090/3","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/90/30090/3"}}},"commit":{"parents":[{"commit":"bca46bf1cff57bc1c0c3c78a6864a1cfa173b063","subject":"chore(snix/nix-daemon): Fix queryValidPaths operation."}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-17 19:18:50.000000000","tz":0},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-18 11:19:56.000000000","tz":0},"subject":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal","message":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal\n\nThis was using a constant, which is fine to eagerly evaluate (as it\nis constant, saves thunking and won\u0027t cause any observable side-effects).\n\nNix probably started eagerly evaluating these at some point, and after\nsome discussion with Robert and Raito, it looks like this is fine and\nLix (where it still is lazy right now) might be open to backport it.\n\nChange the testcase to be a bit more complicated (using `12 + 1`\ninstead of `12`), which still tests what the test wants to primarily\ntest, without failing on these (irrelevant) changes in laziness.\n\nThis means we don\u0027t need to pull in a specific version of Nix in our\nshell.\nThis fixes seeing nix build logs while in the tvix-shell, which was\nbroken on machines not running Nix 2.3.\n\nFixes: https://git.snix.dev/snix/snix/issues/18\nSee-Also: https://github.com/NixOS/nix/issues/12666\nChange-Id: Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752\n"},"branch":"refs/heads/canon"},"64f8cb1400f2b49693f360755805f4debd466fc6":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-03-18 12:06:33.000000000","uploader":{"_account_id":1000003,"name":"clbot","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/90/30090/4","fetch":{"anonymous http":{"url":"https://cl.snix.dev/snix","ref":"refs/changes/90/30090/4","commands":{"Checkout":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.snix.dev/snix refs/changes/90/30090/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.snix.dev/snix refs/changes/90/30090/4"}}},"commit":{"parents":[{"commit":"bca46bf1cff57bc1c0c3c78a6864a1cfa173b063","subject":"chore(snix/nix-daemon): Fix queryValidPaths operation."}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2025-03-17 19:18:50.000000000","tz":0},"committer":{"name":"clbot","email":"clbot@cl.snix.dev","date":"2025-03-18 12:06:33.000000000","tz":0},"subject":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal","message":"fix(nix_oracle): update thunked_formals_fallback_name_resolution_literal\n\nThis was using a constant, which is fine to eagerly evaluate (as it\nis constant, saves thunking and won\u0027t cause any observable side-effects).\n\nNix probably started eagerly evaluating these at some point, and after\nsome discussion with Robert and Raito, it looks like this is fine and\nLix (where it still is lazy right now) might be open to backport it.\n\nChange the testcase to be a bit more complicated (using `12 + 1`\ninstead of `12`), which still tests what the test wants to primarily\ntest, without failing on these (irrelevant) changes in laziness.\n\nThis means we don\u0027t need to pull in a specific version of Nix in our\nshell.\nThis fixes seeing nix build logs while in the tvix-shell, which was\nbroken on machines not running Nix 2.3.\n\nFixes: https://git.snix.dev/snix/snix/issues/18\nSee-Also: https://github.com/NixOS/nix/issues/12666\nChange-Id: Ib7f53bc7ddd8b9f474aecd5315bbfd0599285752\nReviewed-on: https://cl.snix.dev/c/snix/+/30090\nReviewed-by: Ryan Lahfa \u003cmasterancpp@gmail.com\u003e\nAutosubmit: Florian Klink \u003cflokli@flokli.de\u003e\nTested-by: besadii\n"},"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":1000000,"name":"Ryan Lahfa","email":"ryan@lahfa.xyz","username":"raitobezarius"}},{"label":"Verified","status":"MAY","applied_by":{"_account_id":1000002,"name":"besadii","username":"besadii","tags":["SERVICE_USER"]}},{"label":"Autosubmit","status":"MAY","applied_by":{"_account_id":1000004,"name":"Florian Klink","email":"flokli@flokli.de","username":"flokli"}}]}],"submit_requirements":[{"name":"Code-Review","description":"A maximum vote from a non-uploader is required for the \u0027Code-Review\u0027 label. A minimum vote is blocking.","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX,user\u003dnon_uploader"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Verified","description":"Label \u0027Verified+1\u0027 is required","status":"SATISFIED","is_legacy":false,"applicability_expression_result":{"fulfilled":true,"status":"PASS"},"submittability_expression_result":{"expression":"label:Verified\u003dMAX,user\u003dnon_uploader","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX,user\u003dnon_uploader"],"failing_atoms":[],"atom_explanations":{}}},{"name":"No-Unresolved-Comments","description":"Changes that have unresolved comments are not submittable.","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"-has:unresolved","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}}]}